Fix parallel integration test run #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krithika369
force-pushed
the
bugfix_grpc_test
branch
from
7b10158
to
d295a6e
Compare
leonlnj
approved these changes
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a residual change from #6, in the
integration_test/fibergrpc.yamlfile. This was probably not caught earlier because the parallel test run inTestE2EFromConfigwas not working correctly (only the last test was being run because of thettvariable's scope).Fixing the parallel integration test run triggered another error with Data Race which is now addressed in
grpc/codec.go- the setter for the default codec is moved to theNewFiberCodecconstructor, out of the getter function.