Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate grpc dispatch proto marshaling overhead with Codec #5

Merged
merged 7 commits into from
Sep 19, 2022

Conversation

leonlnj
Copy link
Contributor

@leonlnj leonlnj commented Sep 15, 2022

Description

This MR seeks to improve the performance of grpc fiber by reducing proto marshalling overhead by using custom codec.

Fiber will no longer need to know the proto response of the target routes, any request sent to it will be expected to be in []byte. User of Fiber would need to marshal their own proto into Fiber.request.

The byte responses of route will simply be wrapped in the response and the user of Fiber would be expected to unmarshal them into the final proto message.

The default proto codec enforces proto.message on both the request and respond proto. Using the custom codec, this enforcement is loosen for type allowed in the codedc and the marshaling is skipped, making the below connection invocation possible with non proto message.

err := d.conn.Invoke(
		ctx,
		d.serviceMethod,
		grpcRequest.Payload(),
		response,
		grpc.Header(&responseHeader),
		grpc.CallContentSubtype(CodecName),
	)

Changes

  • response.go and request.go - Payload() type changed from interface{} to byte[]
  • grpc/dispatcher.go - Remove server reflection implementation
  • grpc/codec.go - codec implementation

@leonlnj leonlnj self-assigned this Sep 15, 2022
@leonlnj leonlnj marked this pull request as ready for review September 15, 2022 10:06
@leonlnj leonlnj changed the title changing fiber response request to byte. add new implementation of ne… Eliminate grpc dispatch proto marshaling overhead with Codec Sep 15, 2022
@leonlnj leonlnj requested review from pradithya, tiopramayudi and a team September 15, 2022 10:08
grpc/codec.go Outdated Show resolved Hide resolved
grpc/codec.go Outdated Show resolved Hide resolved
grpc/dispatcher.go Outdated Show resolved Hide resolved
grpc/codec.go Outdated Show resolved Hide resolved
Copy link
Member

@pradithya pradithya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for this huge performance improvement!

@leonlnj leonlnj merged commit e1bb222 into gojek:main Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants