Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-duplicate subscription calls #39

Merged
merged 21 commits into from
Feb 7, 2024
Merged

De-duplicate subscription calls #39

merged 21 commits into from
Feb 7, 2024

Conversation

ajatprabha
Copy link
Member

@ajatprabha ajatprabha commented Feb 6, 2024

When using Option such as OnConnectHandler, the delegated paho library calls it in a separate goroutine as soon as the connection is open to a broker.

This change makes sure that in case of a shared subscription, actual subscription is called only once per client.

@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cd5858c) 99.70% compared to head (c93c894) 99.72%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
+ Coverage   99.70%   99.72%   +0.01%     
==========================================
  Files          32       32              
  Lines         681      720      +39     
==========================================
+ Hits          679      718      +39     
  Misses          2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ajatprabha ajatprabha merged commit fcaba40 into main Feb 7, 2024
3 checks passed
@ajatprabha ajatprabha deleted the dedup-subs branch February 7, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants