math: Add cube root function #12683
Closed
math: Add cube root function #12683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm closing this. PRs with new template functions/features needs to come via an accepted proposal. You could argue that this somehow "completes" earlier work in this area, but that argument can certainly be used for just about every new feature, and then we have a never ending story. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The final PR of this series adds the cube root function. While it could be computed via fractional powers, providing a dedicated function has benefits. F.e. it is faster and avoids corner cases. Equally important, it is much clearer to write and read. (Which is especially important as go templates can quickly become convoluted.)