Switch EXIF library #12651
Merged
Switch EXIF library #12651
+284
−181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
bep
force-pushed
the
feat/exif-10855
branch
5 times, most recently
from
d21e7e0
to
a569d73
Compare
bep
force-pushed
the
feat/exif-10855
branch
10 times, most recently
from
43e7d79
to
b6edcab
Compare
Closes gohugoio#10855 Closes gohugoio#8586 Closes gohugoio#8996
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some minor technical issues left to do on this issue, but this should be mostly OK.
This commit switches the Go library used for
EXIFto one written from scratch by me. The specifications/implementations on this are all over the place, and to stop endless discussions, I decided to make Exiftool the source of truth.This also brings EXIF support for
WebPandPNGin addition toJPEGandTIFF.The imagemeta library also supports
XMPandIPTCmetadata, but that requires an API change on the Hugo side, so that needs to be taken as a later task.This should mostly work as before (only much faster). There are some tag names that have changed names, and there's a new
imagemeta.Rattype that replacesmath/big.Ratfor rational numbers, but if you just print these numbers, you will not notice.Closes #10855
Closes #8586