Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deadlock config.Get when config section does not exist #8791

Closed
bep opened this issue Jul 26, 2021 · 1 comment · Fixed by #8793
Closed

Deadlock config.Get when config section does not exist #8791

bep opened this issue Jul 26, 2021 · 1 comment · Fixed by #8793
Assignees
@bep
Labels
Bug Outdated

Comments

@bep
Copy link
Member

bep commented Jul 26, 2021

We don't have any existing tests failing with this, and I don't know of any Hugo site failing with this, but I think we need to get this fix out sooner rather than later.
@bep bep self-assigned this Jul 26, 2021
@bep bep added the Bug label Jul 26, 2021
bep added a commit to bep/hugo that referenced this issue Jul 26, 2021
@bep
Deprecate Blackfriday and fix a potential deadlock in config
e014dfa 
Note that the deadlock has not been seen earlier, in tests on in real Hugo sites.

Fixes gohugoio#8792
Fixes gohugoio#8791
@bep bep mentioned this issue Jul 26, 2021
Merged
@bep bep closed this as completed in #8793 Jul 26, 2021
bep added a commit that referenced this issue Jul 26, 2021
@bep
Deprecate Blackfriday and fix a potential deadlock in config
c725222 
Note that the deadlock has not been seen earlier, in tests on in real Hugo sites.

Fixes #8792
Fixes #8791
bep added a commit that referenced this issue Jul 30, 2021
@bep
config: Fix a potential deadlock in config reading
94b616b 
Note that the deadlock has not been seen earlier, in tests on in real Hugo sites.

Fixes #8791
@bot-actions bot-actions bot mentioned this issue Aug 2, 2021
Merged
This was referenced Aug 2, 2021
Merged
Merged
@bot-actions bot-actions bot mentioned this issue Aug 4, 2021
Merged
This was referenced Aug 9, 2021
Merged
Merged
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bep bep

Labels
Bug Outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecate Blackfriday and fix a potential deadlock in config bep/hugo
1 participant
@bep