Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inaccessible task list markup #3303

Closed
Heydon opened this issue Apr 8, 2017 · 3 comments · Fixed by #3774
Closed

Inaccessible task list markup #3303

Heydon opened this issue Apr 8, 2017 · 3 comments · Fixed by #3774

Comments

@Heydon
Copy link

Heydon commented Apr 8, 2017

Hi! Great product. Just thought you ought to know the rendered markup for task lists (https://gohugo.io/content/markdown-extras) is inaccessible i.e. the checkboxes are not correctly labeled.

<ul class="task-list">
  <li><input type="checkbox" disabled="" class="task-list-item"> a task list item</li>
  <li><input type="checkbox" disabled="" class="task-list-item"> list syntax required</li>
  <li><input type="checkbox" disabled="" class="task-list-item"> incomplete</li>
  <li><input type="checkbox" checked="" disabled="" class="task-list-item"> completed</li>
</ul>

You can fix this by wrapping the input and text in a <label>:

<ul class="task-list">
<li><label><input type="checkbox" disabled="" class="task-list-item"> a task list item</label></li>
<li><label><input type="checkbox" disabled="" class="task-list-item"> list syntax required</label></li>
<li><label><input type="checkbox" disabled="" class="task-list-item"> incomplete</label></li>
<li><label><input type="checkbox" checked="" disabled="" class="task-list-item"> completed</label></li>
</ul>
@bep bep added the Enhancement label Apr 8, 2017
@bep
Copy link
Member

bep commented Apr 8, 2017

Thanks ... You should tell that to GitHub as well; I think I ripped the markup from them.

@Heydon
Copy link
Author

Heydon commented Apr 8, 2017

@bep Yeah, fair enough! 😁

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants