-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump golang 1.21.5 & fix golangci-lint error #19722
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #19722 +/- ##
=======================================
Coverage 67.55% 67.55%
=======================================
Files 991 991
Lines 109175 109168 -7
Branches 2719 2719
=======================================
Hits 73752 73752
+ Misses 31456 31448 -8
- Partials 3967 3968 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
MinerYang
force-pushed
the
bump_golang_1.21.5
branch
from
December 18, 2023 06:27
a944c47
to
7ba1f55
Compare
MinerYang
changed the title
bump golang 1.21.5
bump golang 1.21.5 & fix goalngci-lint error
Dec 18, 2023
MinerYang
changed the title
bump golang 1.21.5 & fix goalngci-lint error
bump golang 1.21.5 & fix golangci-lint error
Dec 18, 2023
update golangci-lint && fix revive error fix white space lint Signed-off-by: yminer <yminer@vmware.com>
MinerYang
force-pushed
the
bump_golang_1.21.5
branch
from
December 18, 2023 06:42
7ba1f55
to
800c5b0
Compare
YangJiao0817
approved these changes
Dec 18, 2023
wy65701436
approved these changes
Dec 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
altynbaev
pushed a commit
to altynbaev/harbor
that referenced
this pull request
Jan 29, 2024
bump golang 1.21.5 update golangci-lint && fix revive error fix white space lint Signed-off-by: yminer <yminer@vmware.com> Signed-off-by: Altynbaev Dinislam <altynbayevdr@sberautotech.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
#19719
Please indicate you've done the following: