Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set root password never expire #11635

Merged
merged 1 commit into from
Apr 16, 2020

Conversation

hyy0322
Copy link
Contributor

@hyy0322 hyy0322 commented Apr 15, 2020

For harbor-log container,

root [ / ]# chage -l root
Last password change					: Apr 15, 2020
Password expires					: Jul 14, 2020
Password inactive					: never
Account expires						: never
Minimum number of days between password change		: 0
Maximum number of days between password change		: 90
Number of days of warning before password expires	: 7

When run sudo -u \#10000 -E 'rsyslogd' '-n', after 90 days you build image, it requires password change.
Fix: #11633

Signed-off-by: Yiyang Huang <huangyiyang@caicloud.io>
@hyy0322 hyy0322 force-pushed the set-root-password-never-expire branch from fcc1ebd to 4598f52 Compare April 15, 2020 16:15
@codecov
Copy link

codecov bot commented Apr 15, 2020

Codecov Report

Merging #11635 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11635      +/-   ##
==========================================
+ Coverage   55.55%   55.57%   +0.02%     
==========================================
  Files         910      910              
  Lines       52680    52680              
  Branches     1788     1788              
==========================================
+ Hits        29267    29278      +11     
+ Misses      20148    20137      -11     
  Partials     3265     3265              
Flag Coverage Δ
#unittests 55.57% <ø> (+0.02%) ⬆️
Impacted Files Coverage Δ
...ortal/src/lib/components/config/gc/gc.component.ts 59.37% <0.00%> (-3.13%) ⬇️
.../goharbor/harbor/src/jobservice/period/enqueuer.go 68.38% <0.00%> (+1.47%) ⬆️
...ig/vulnerability/vulnerability-config.component.ts 52.22% <0.00%> (+4.45%) ⬆️
.../src/pkg/permission/evaluator/rbac/casbin_match.go 100.00% <0.00%> (+10.00%) ⬆️

Copy link
Member

@ninjadq ninjadq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ninjadq ninjadq merged commit 9c7cadd into goharbor:master Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sudo version 1.8.30 behave change which breaks harbor service after password expired
3 participants