Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TabBar size when theme changes #88293

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Fix TabBar size when theme changes #88293

merged 1 commit into from
Feb 13, 2024

Conversation

WhalesState
Copy link
Contributor

Fixes: #87511

@WhalesState WhalesState requested a review from a team as a code owner February 13, 2024 17:50
@AThousandShips AThousandShips added this to the 4.3 milestone Feb 13, 2024
@AThousandShips AThousandShips added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Feb 13, 2024
YeldhamDev
YeldhamDev requested changes Feb 13, 2024
View reviewed changes
Copy link
Member

@YeldhamDev YeldhamDev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be in this order, like the other instances in the file:

scene/gui/tab_bar.cpp Outdated Show resolved Hide resolved
@akien-mga akien-mga merged commit cea77f8 into godotengine:master Feb 13, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@WhalesState WhalesState deleted the tab_bar branch February 13, 2024 23:39
@wez470
Copy link

wez470 commented Feb 15, 2024

Thank you!

@Cammymoop Cammymoop mentioned this pull request Feb 20, 2024
Closed
@akien-mga
Copy link
Member

Cherry-picked for 4.2.2.

@akien-mga akien-mga removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Mar 11, 2024
@AeioMuch AeioMuch mentioned this pull request Apr 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YeldhamDev YeldhamDev YeldhamDev approved these changes

Assignees
No one assigned
Labels
bug topic:gui
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

TabContainer Floating Tabs
5 participants
@WhalesState @akien-mga @wez470 @YeldhamDev @AThousandShips