Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TabContainer Floating Tabs #87511

Closed
wez470 opened this issue Jan 23, 2024 · 6 comments · Fixed by #88293
Closed

TabContainer Floating Tabs #87511

wez470 opened this issue Jan 23, 2024 · 6 comments · Fixed by #88293
Milestone

Comments

@wez470
Copy link

wez470 commented Jan 23, 2024

Tested versions

System information

Godot v4.2.stable - Windows 10.0.22000 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 2070 SUPER (NVIDIA; 31.0.15.3713) - Intel(R) Core(TM) i7-9700K CPU @ 3.60GHz (8 Threads)

Issue description

TabContainer tabs render fine in the 4.1 version of Godot I've listed above. In 4.2, they float above the tab panel and seem to shrink as much as they can around the tab text. Toggling various settings (e.g. Clip Tabs on the TabContainer) seems to fix the issue.

TabContainerBug.mp4

Steps to reproduce

  • Create a tab container with a couple tabs in 4.2
  • Increase font size on the tab container
  • Play the project
  • Remote toggle Clip Tabs on the TabContainer to see the rendering fix itself.
  • Open the project in 4.1 to see the issue is gone.

Minimal reproduction project (MRP)

TabContainerTest.zip

@WhalesState
Copy link
Contributor

WhalesState commented Jan 23, 2024

I'm using 4.2.1, and win 10, the tab container works fine, can you please test it with the latest stable 4.2.1 editor ?
https://godotengine.org/download/windows/

Also the MRP TabContainerTest.zip size is 6.5 mb because of the shader cache inside the .godot folder.

here's the MRP without the .godot folder TabContainerTest.zip and it's just 3 kb

I have tested with the latest stable release 4.2.1!

tab-container-issue.mp4

@devloglogan
Copy link
Contributor

Using the MRP, issue appears present on 4.2 branch. Opening it with master, bug cannot be recreated.

@whatiscraig
Copy link

I wanted to add that this issue is still present. Change the font size or add a custom font to a TabContainer and the tabs will be misaligned. Togging a setting will fix the issue, but it will return when you load the scene or run the project.

@Calinou
Copy link
Member

Calinou commented Feb 12, 2024

@omgcraig Which Godot version did you test this on? @devloglogan's comment said that this issue can't be reproduced more on latest master (try 4.3.dev3).

@whatiscraig
Copy link

I'm found that on Godot 4.3 Dev 3, if you create a TabContainter with a few tabs, add a theme then add a custom font, the tabs will pop out and be misaligned.

@WhalesState
Copy link
Contributor

This issue is related to the TabBar node not the TabContainer. I will try to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants