Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on late mouse enter/exit event arrival. #85418

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Nov 27, 2023

Fix #85395 (crash part).

On export errors, mouse leave/enter events can arrive after the window is removed from the tree (probably due to editor popup repainting logic and export process blocking main thread for the long periods).

@bruvzg bruvzg added this to the 4.3 milestone Nov 27, 2023
@bruvzg bruvzg requested a review from a team as a code owner November 27, 2023 06:51
@bruvzg bruvzg modified the milestones: 4.3, 4.2 Nov 27, 2023
Copy link
Contributor

@Sauermann Sauermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The checks here make sense to me. Didn't test the MRP of the linked issue.

@akien-mga akien-mga merged commit a807d4b into godotengine:master Nov 27, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash on Exporting Android AAB using 'Hello World' Sample Android Plugin in Godot 4.2.rc2
4 participants