Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where maximized->fullscreen->windowed mode stays maximized. #84504

Merged

Conversation

jitspoe
Copy link
Contributor

@jitspoe jitspoe commented Nov 6, 2023

Fix #84143

@jitspoe jitspoe requested a review from a team as a code owner November 6, 2023 07:39
@bruvzg bruvzg self-requested a review November 6, 2023 08:56
@Calinou Calinou added bug platform:windows topic:porting cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Nov 6, 2023
@Calinou Calinou added this to the 4.2 milestone Nov 6, 2023
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally on Windows 11 22H2, it works as expected. I couldn't notice any regressions from switching between modes.

Note that this doesn't affect the Maximized -> Minimized behavior (window is restored to its normal size after alt-tabbing instead of being maximized).

@akien-mga akien-mga merged commit 0e8781e into godotengine:master Nov 9, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DisplayServer.window_set_mode() is stuck on maximized window after changing mode
5 participants