OpenGL: Fix uninitialized memory usage for GPUParticles interp_to_end
#84189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clayjohn
approved these changes
Oct 30, 2023
YuriSizov
reviewed
Oct 30, 2023
There was a problem hiding this comment.
Just leaving a comment in there that ParticlesFrameParams doesn't initialize any scalar members at all.
There was a problem hiding this comment.
ParticlesFramesParams initializes everything when it is used
There was a problem hiding this comment.
Until we forget to set one new member added to the struct ;)
But I guess in that case we might prefer a bug than a safe default value that hides not properly respecting the configuration.
YuriSizov
approved these changes
Oct 30, 2023
akien-mga
changed the title
interp_to_endinterp_to_end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #84072.