Fix LightmapGI taking editor-only and sky-only lights into account #83861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These lights are not visible when running the project (or at all), so they shouldn't affect the lightmap baking process.
|
Nice fix, this help me to not disable the light mode before baking :) |
akien-mga
reviewed
Oct 24, 2023
| @@ -52,7 +52,7 @@ | |||
| [b]Note:[/b] Only effective for [OmniLight3D] and [SpotLight3D], and only when [member shadow_enabled] is [code]true[/code]. | |||
| </member> | |||
| <member name="editor_only" type="bool" setter="set_editor_only" getter="is_editor_only" default="false"> | |||
| If [code]true[/code], the light only appears in the editor and will not be visible at runtime. | |||
| If [code]true[/code], the light only appears in the editor and will not be visible at runtime. If [code]true[/code], the light will never be baked in [LightmapGI] regardless of its [member light_bake_mode]. | |||
There was a problem hiding this comment.
Repeating "if true" sounds repetitive. How about "Additionally,"?
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These lights are not visible when running the project (or at all), so they shouldn't affect the lightmap baking process.
VoxelGI already takes care of sky-only lights, but not editor only lights (I've looked and didn't find a way to implement it).