Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add property hint for 2D shadow size project setting #83760

Merged
merged 1 commit into from
Oct 22, 2023

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Oct 21, 2023

Previously, it was possible to use zero or negative values, which are invalid.

This also prevents crashing the engine by setting a shadow size of 0 or lower from a script. This effectively bricked the editor on a specific project if a negative value was saved to project.godot (until you modified it with a text editor).

Previously, it was possible to use zero or negative values, which are
invalid.

This also prevents crashing the engine by setting a shadow size of
0 or lower from a script.
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense and LGTM

@akien-mga akien-mga merged commit 9fb3c42 into godotengine:master Oct 22, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants