Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow normal maps on TileMaps that use texture padding #83489

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Allow normal maps on TileMaps that use texture padding #83489

merged 1 commit into from
Oct 18, 2023

Conversation

groud
Copy link
Member

@groud groud commented Oct 17, 2023 •
edited
Loading

Closes #61832

I added it for 4.2 and used the "bug" as the original issue is labeled the same. But I guess, if that's too risky, it could be moved to 4.3.

@groud groud added this to the 4.2 milestone Oct 17, 2023
@groud groud requested a review from a team as a code owner October 17, 2023 10:12
@kleonc kleonc mentioned this pull request Oct 17, 2023
Closed
@kleonc
Copy link
Member

kleonc commented Oct 17, 2023

Supersedes #79823. It's simpler and I forgot reacting on changed signal in there anyway, closed it in favor of this one. 👍

@YuriSizov YuriSizov requested a review from KoBeWi October 17, 2023 13:43
@akien-mga akien-mga merged commit 65e7dda into godotengine:master Oct 18, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@AThousandShips AThousandShips mentioned this pull request Oct 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuriSizov YuriSizov YuriSizov left review comments

@KoBeWi KoBeWi KoBeWi approved these changes

Assignees
No one assigned
Labels
bug topic:2d
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Unable to retrieve normal map from CanvasTexture atlas in TileSet/TileMap
5 participants
@groud @kleonc @akien-mga @KoBeWi @YuriSizov