Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GDScript: Fix non-static call is allowed in static var lambda body #83486

Merged
merged 1 commit into from
Oct 20, 2023
Merged

GDScript: Fix non-static call is allowed in static var lambda body #83486

merged 1 commit into from
Oct 20, 2023

Conversation

dalexeev
Copy link
Member

@dalexeev dalexeev added this to the 4.2 milestone Oct 17, 2023
@dalexeev dalexeev requested a review from a team as a code owner October 17, 2023 09:47
@dalexeev dalexeev force-pushed the gds-fix-call-non-static-in-static-var-lambda branch from e9b3d1b to 3694f0b Compare October 17, 2023 10:09
@adamscott adamscott requested a review from vnen October 17, 2023 13:27
vnen
vnen approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@vnen vnen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dalexeev dalexeev force-pushed the gds-fix-call-non-static-in-static-var-lambda branch from 3694f0b to 20906f0 Compare October 17, 2023 14:26
@dalexeev dalexeev marked this pull request as draft October 17, 2023 14:45
@dalexeev dalexeev force-pushed the gds-fix-call-non-static-in-static-var-lambda branch from 20906f0 to 99c7dd3 Compare October 20, 2023 15:49
@dalexeev dalexeev marked this pull request as ready for review October 20, 2023 15:49
@dalexeev dalexeev force-pushed the gds-fix-call-non-static-in-static-var-lambda branch from 99c7dd3 to 7f4721a Compare October 20, 2023 17:43
@akien-mga akien-mga merged commit b075c61 into godotengine:master Oct 20, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@dalexeev dalexeev deleted the gds-fix-call-non-static-in-static-var-lambda branch October 20, 2023 21:46
@raccoon-path raccoon-path mentioned this pull request Nov 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga left review comments

@vnen vnen vnen approved these changes

Assignees
No one assigned
Labels
bug topic:gdscript
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Opcode 88 when making a Dictionary with Callable values in GDScript
3 participants
@dalexeev @akien-mga @vnen