Fix phantom tab right button #83296
Merged
Fix phantom tab right button #83296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YeldhamDev
requested changes
Oct 13, 2023
Wierdox
force-pushed
the
fix_phantom_tab_right_button
branch
from
19d962e
to
7b33ad3
Compare
YeldhamDev
approved these changes
Oct 14, 2023
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #83232
Was caused by only updating the right button
rb_rectof a tab if the texture was valid. Therefore, it would never be updated when texture isnulland so keep its size forever.Solved by adding a branch to its update logic in
TabBar::_draw_tab()to setrb_rectto an emptyRect2.