Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GDScript cache assigning UID as scene path #83039

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Oct 9, 2023

Fixes #82701

@KoBeWi KoBeWi added this to the 4.2 milestone Oct 9, 2023
@KoBeWi KoBeWi requested a review from a team as a code owner October 9, 2023 11:57
Copy link
Member

@reduz reduz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not my area so I am not sure if this is correct, but it if the problem is that the cache needs an actual path and its getting an UID path, then this looks good.

Copy link
Member

@adamscott adamscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't be fooled by the number of lines it changes, it only adds 3 lines (the uid check). The rest is the same logic, with a different variable name.

Works well for me.

@akien-mga akien-mga merged commit a9c864d into godotengine:master Nov 10, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the it's_always_the_cache branch November 10, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't preload resource uid for PackedScene.
4 participants