Make gizmo plugin handle SpriteBase3D instead of Sprite3D
#82901
+23
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Oct 6, 2023
akien-mga
approved these changes
Oct 6, 2023
kleonc
force-pushed
the
sprite-base-3d-gizmo-plugin
branch
from
1a5ee00
to
cdae834
Compare
Initially I've changed only the handled type but seeing other gizmo plugins for base classes like |
kleonc
force-pushed
the
sprite-base-3d-gizmo-plugin
branch
from
cdae834
to
db6a895
Compare
|
Thanks! |
|
Thanks @kleonc ! That was fast. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #82873. There was no gizmo plugin handling
AnimatedSprite3D... 🙃Replaces
Sprite3DGizmoPluginwithSpriteBase3DGizmoPlugin(rename + changed handled type fromSprite3DtoSpriteBase3D).Removes redundant
AnimatedSprite3D::centeredmember which was alwaysfalse. It was used only inAnimatedSprite3D::get_item_rect()where it was incorrectly checked instead ofSpriteBase3D::centered(which isprivateand hence needs to be checked withSpriteBase3D::is_centered()). This buggy check wasn't affecting anything before this PR asAnimatedSprite3D::get_item_rect()is called only withinSpriteBase3D::generate_triangle_mesh()which was never called for anAnimatedSprite3Das there was no gizmo plugin handling it. With a gizmo plugin handlingAnimatedSprite3Dadded it was making it selectable by the non-centered area regardless of thecenteredproperty value.