Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide translation strings for folder colors #82858

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Oct 5, 2023

Addresses #80440 (comment)
I hope the string extractor doesn't ignore comments >_>

@KoBeWi KoBeWi added this to the 4.2 milestone Oct 5, 2023
@KoBeWi KoBeWi requested a review from a team as a code owner October 5, 2023 15:22
Copy link
Contributor

@YuriSizov YuriSizov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, if it works... 🙃 Could probably replace Color with Pair<Color, String> in the hashmap, though.

Copy link
Member

@timothyqiu timothyqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels hacky to use the fact that we extract strings without considering comments ;)

But anyway, it should be relatively easy to modify the code here if we need to modify that extraction behavior later.

@akien-mga akien-mga merged commit 060816c into godotengine:master Oct 17, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the read_between_the_comments branch October 17, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants