Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some typos in source #82779

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Fix some typos in source #82779

merged 1 commit into from
Oct 4, 2023

Conversation

emacser0
Copy link
Contributor

@emacser0 emacser0 commented Oct 4, 2023 •
edited
Loading

"wihout" -> "without"
"mutli" -> "multi"
"maxium" -> "maximum"

@emacser0 emacser0 requested review from a team as code owners October 4, 2023 10:34
@AThousandShips AThousandShips changed the title Fix some typo in source. Fix some typos in source. Oct 4, 2023
@AThousandShips AThousandShips mentioned this pull request Oct 4, 2023
Closed
@AThousandShips
Copy link
Member

AThousandShips commented Oct 4, 2023 •
edited
Loading

As mentioned in your first PR the code under thirdparty shouldn't be changed

@AThousandShips AThousandShips added this to the 4.x milestone Oct 4, 2023
@emacser0
Copy link
Contributor Author

emacser0 commented Oct 4, 2023 •
edited
Loading

Sorry for my mistakes, I saw your message after creating this pull request.
I will fix all you mentioned and reopen pull request again if I'm ready.
That was my first PR in this repository so I made a lot of mistakes.

Thank you for your review.

@AThousandShips
Copy link
Member

You do not have to open a new PR, just update this one

@emacser0
Copy link
Contributor Author

emacser0 commented Oct 4, 2023

I fixed mistakes you mentioned. Thank you for your feedback.

@YuriSizov YuriSizov changed the title Fix some typos in source. Fix some typos in source Oct 4, 2023
@akien-mga akien-mga modified the milestones: 4.x, 4.2 Oct 4, 2023
@akien-mga akien-mga merged commit bfd78bb into godotengine:master Oct 4, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips left review comments

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement topic:codestyle
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@emacser0 @AThousandShips @akien-mga