Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use theme icon size when calculating category minimum size #82540

Merged

Conversation

jackwilsdon
Copy link
Contributor

@jackwilsdon jackwilsdon commented Sep 29, 2023

This previously used the underlying size of the icon, causing the category to grow incorrectly when re-rendered (e.g. via switching tabs at the top of the inspector):

Before After

Fixes #82527

This previously used the underlying size of the icon, causing the
category to grow incorrectly when re-rendered.

Fixes godotengine#82527
@akien-mga akien-mga requested a review from a team September 29, 2023 17:57
@akien-mga akien-mga added this to the 4.2 milestone Sep 29, 2023
@akien-mga akien-mga merged commit eb14308 into godotengine:master Sep 30, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@jackwilsdon jackwilsdon deleted the fix-inspector-category-height branch September 30, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inspector sections with big custom icons don't shrink properly
3 participants