Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Some nodes are referenced by animation tracks" when deleting instance #82486

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

timothyqiu
Copy link
Member

Fixes #81491

Currently, checks for skipping AnimationPlayer node is done by checking whether the root_node property references the deleted nodes. It will prompt for track deletion if the scene looks like this:

  • Scene
    • DeleteThisNode
      • RootNodeOfAnimationPlayer
        • AnimationPlayer

@timothyqiu timothyqiu added this to the 4.2 milestone Sep 28, 2023
@timothyqiu timothyqiu requested a review from a team as a code owner September 28, 2023 14:47
@timothyqiu timothyqiu requested review from KoBeWi and removed request for a team September 28, 2023 14:47
@akien-mga akien-mga merged commit e19acaa into godotengine:master Oct 23, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@timothyqiu timothyqiu deleted the the-node-who-lived branch October 23, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Some nodes are referenced by animation tracks" when deleting instance
3 participants