[GLES3] Avoid freeing proxy textures clearing owner's data #82430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomShaper
force-pushed
the
fix_gles3_tex_free
branch
2 times, most recently
from
4f9b961
to
06b98a5
Compare
RandomShaper
force-pushed
the
fix_gles3_tex_free
branch
from
06b98a5
to
a675599
Compare
akien-mga
changed the title
clayjohn
approved these changes
Oct 26, 2023
clayjohn
added
the
cherrypick:4.1
|
Thanks! |
akien-mga
changed the title
YuriSizov
removed
the
cherrypick:4.1
|
Cherry-picked for 4.1.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps with the error message in #79286 (
ERROR: Condition "!texture_allocs_cache.has(p_id)" is true.). However, it doesn't fix the crash. All in all, I'm not familiar enough with this at the moment, so please review carefully.