Color match editor log toggles and flat pressed buttons #82365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Sep 26, 2023
YuriSizov
force-pushed
the
editor-colormatch-pressed-buttons
branch
from
548a0f2
to
cdec1ee
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One thing that I didn't account for in #81939 was that we have these special-style toggle buttons in the editor log, and right next to them we have flat toggle buttons. With the new style it looks pretty meh together.
So I've adjusted the colors of the new flat buttons and made sure that the editor log filters also use the same colors. I also added a separator to the editor log sidebar to separate buttons which do immediate actions from buttons which have toggle behavior.
I've debated a bit if we should completely match the style of the editor log filters with flat buttons, but decided to avoid drowning in bikeshedding on this one. There was a reason to add borders, but these borders don't work well if applied to every flat button. Also making filters flat makes them less clear in the disabled state. So I kept them as is, with their unique features. Just made sure that pressed colors are the same.