GDScript: Fix crash with GDScriptNativeClass
#82294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dalexeev
commented
Sep 25, 2023
dalexeev
commented
- Fixes Godot Crashes Immediately Upon Opening Project #82255.
akien-mga
reviewed
Sep 25, 2023
dalexeev
force-pushed
the
gds-fix-gdsnc-crash
branch
from
bd00d95
to
da920b0
Compare
|
I haven't tested, but I think this may fix the crash from these GDExtension-related issues as well: godotengine/godot-cpp#1249, #81478, #80850 (There may still be an issue with the order that GDExtension's are loaded relative to GDScripts getting compiled, but that should be an error rather than a crash) |
dalexeev
force-pushed
the
gds-fix-gdsnc-crash
branch
from
da920b0
to
16b024b
Compare
akien-mga
approved these changes
Sep 25, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.