Polish a few things in Vulkan RD #81912
Conversation
| @@ -5918,7 +5918,7 @@ Error RenderingDeviceVulkan::buffer_copy(RID p_src_buffer, RID p_dst_buffer, uin | |||
|
|
|||
| // This method assumes the barriers have been pushed prior to being called, therefore no barriers are pushed | |||
| // for the source or destination buffers before performing the copy. These masks are effectively ignored. | |||
| VkPipelineShaderStageCreateFlags src_stage_mask = 0; | |||
| VkPipelineStageFlags src_stage_mask = 0; | |||
There was a problem hiding this comment.
This worked because in the end it's a plain int, but was the wrong typedef.
| // Should not be needed. | ||
| // _buffer_memory_barrier(buffer->buffer, p_offset, p_size, dst_stage_mask, VK_PIPELINE_STAGE_TRANSFER_BIT, dst_access, VK_ACCESS_TRANSFER_WRITE_BIT, p_post_barrier); |
There was a problem hiding this comment.
By now we'd already know. Anyway, we can always find out it's not true and re-add, tracking this removal if needed.
| @@ -6050,7 +6047,7 @@ Error RenderingDeviceVulkan::buffer_clear(RID p_buffer, uint32_t p_offset, uint3 | |||
| dst_stage_mask = VK_PIPELINE_STAGE_BOTTOM_OF_PIPE_BIT; | |||
| } | |||
|
|
|||
| _buffer_memory_barrier(buffer->buffer, p_offset, p_size, VK_PIPELINE_STAGE_TRANSFER_BIT, dst_stage_mask, VK_ACCESS_TRANSFER_WRITE_BIT, dst_access, dst_stage_mask); | |||
| _buffer_memory_barrier(buffer->buffer, p_offset, p_size, VK_PIPELINE_STAGE_TRANSFER_BIT, dst_stage_mask, VK_ACCESS_TRANSFER_WRITE_BIT, dst_access, true); | |||
There was a problem hiding this comment.
This worked before the change because dst_stage_mask would always be non-zero, that is, true would be passed as the argument, but the code was awkward.
There was a problem hiding this comment.
buffer_update() above is very similar to this function but it wraps this barrier in a condition. Should this function also have the condition?
There was a problem hiding this comment.
It's very likely, but since this PR aims to be about very silly little things, the reasoning to be sure is out of its scope.
RandomShaper
force-pushed
the
polish_vk
branch
from
91fe43f
to
8aa9b6a
Compare
RandomShaper
force-pushed
the
polish_vk
branch
from
8aa9b6a
to
bda6fc5
Compare
|
Thanks! |
A few little silly things. Summoning Production as reviewer, since this is not even about rendering, but area-agnostic code maintenance.
(Comments added to the changes via GH feature about why each change.)