Fixed VS 2022 Mac compatibility

[Nomad1]

Visual Studio 2022 on Mac marks the project as invalid if the project Guid is set. The easiest way to fix it is to add an additional check and disable 'EnableGodotProjectTypeGuid' for the SDK when the Visual Studio version is less than 17.0.

Bugsquad edit:

• Fixes Visual Studio can't open Godot 4 C# solution on Mac OSX 12.5 #67029.

[RedworkDE]

See also the issue about this: #67029
How does this PR behave in regard to the SDK issues and Godot plugin mentioned there?
Is there a better way to detect VS for mac? If not what are the consequences of removing that GUID for VS 2019 and earlier on windows?

[Nomad1]

See also the issue about this: #67029 How does this PR behave in regard to the SDK issues and Godot plugin mentioned there? Is there a better way to detect VS for mac? If not what are the consequences of removing that GUID for VS 2019 and earlier on windows?

It fixes the abovementioned issue for VS 2022 Mac. Restoring the Nuget projects makes VS 2022 fully working, even without the Godot Addin (Addin could not be fixed ATM since there is no recent version of MonoDevelop.AddinMaker).
The condition allows it to work with VS 2019 Mac but I can't check the earlier versions.
Will re-check it on Windows tomorrow and maybe add one more condition to avoid issues there.

[Nomad1]

Test results.

Mac

[-] VS 2017: broken, might work if addin is installed

• addins are not working anymore - repository is down
• .NET SDK 6.0 and 7.0 detected in corresponding folders
• project is not opening when ProjectTypeGuid is set, removing it allows the project to open
• Godot libraries are not resolved
• can't compile, unknown error

[*] VS 2019: broken on M1 might work on Intel

• addin is installed and working
• .NET SDK 6.0-7.0 cannot be found on M1
• project is opening, regardless of ProjectTypeGuid
• Godot libraries are not resolved on M1
• can't compile on M1

[+] VS 2022: works

• addin could not be installed, major compatibility issues
• SDK detected
• project is opening only if ProjectTypeGuid is disabled
• Godot libraries are resolved after Nuget Restore
• compiles without any issues

[+] VS Code: works

• addin works
• SDK detected
• project always opens (you can't break it, it works on folder level not with the .csproj)
• Godot libraries are resolved
• compiles with MSBuild, can fail if no .NET SDK is installed

Windows

[-] VS 2019: doesn't support .Net 6.0 even with Preview Features hack

• no addin available for Godot 4.x and VS 2019
• .NET SDK installed and MSBuild sees it, but not the Visual Studio
• project is opening regardless of ProjectTypeGuid
• Godot libraries are downloaded with Nuget but not loaded
• doesn't compile

[+] VS 2022: works

• addin not in the repository, haven't checked the one from the github
• SDK detected
• project is opening every time
• Godot libraries are resolved
• compiles without any issues

[+] VS Code: works

• addin works
• SDK detected
• project always opens (you can't break it, it works on folder level not with the .csproj)
• Godot libraries are resolved
• compiles with MSBuild, can fail if no .NET SDK is installed

** Conclusion **
Since migrating from Mono to .Net 6+ we are restricted to MSBuild project types and the latest Visual Studio versions that don't rely on ProjectTypeGuid but sometimes fail if it's invalid. There is literally zero need for it anymore for the 4.x branch. Visual Studio Code is the main future target for Godot C# development and is not affected by the .csproj files at all.
I vote to remove the EnableGodotProjectTypeGuid or force it to false without any extra condition.

[raulsntos]

The ProjectTypeGuid has already been removed in 3.x (see cd339ff), the reasoning was:

The property has no effect as the older VS project system doesn't
work with Sdk style projects.

The presence of the property was preventing Visual Studio for Mac
from opening the project if the Godot extension is not installed.

So I think it makes sense to remove it altogether.

[Nomad1]

The ProjectTypeGuid has already been removed in 3.x (see cd339ff), the reasoning was:

The property has no effect as the older VS project system doesn't
work with Sdk style projects.
The presence of the property was preventing Visual Studio for Mac
from opening the project if the Godot extension is not installed.

So I think it makes sense to remove it altogether.

Removed and committed new code.

[raulsntos]

You'll have to remove <GodotProjectTypeGuid> from Sdk.props as well (see the linked commit cd339ff).

Also, you'll need to squash the commits before this PR can be merged. The contributing documentation contains information about squashing in case you need it.

Feel free to reach out in the development chat if you need help.

[raulsntos]

Looks good to me, thanks!

[akien-mga]

Thanks! And congrats for your first merged Godot contribution 🎉

[akien-mga]

Cherry-picked for 4.1.2.