Update folder colors when moving or renaming #81380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
force-pushed
the
folder_color_add
branch
2 times, most recently
from
4560edd
to
b442ebe
Compare
KoBeWi
reviewed
Sep 7, 2023
KoBeWi
reviewed
Sep 7, 2023
AThousandShips
force-pushed
the
folder_color_add
branch
from
b442ebe
to
36ffb06
Compare
KoBeWi
reviewed
Sep 7, 2023
KoBeWi
reviewed
Sep 7, 2023
KoBeWi
approved these changes
Sep 7, 2023
KoBeWi
reviewed
Sep 7, 2023
AThousandShips
force-pushed
the
folder_color_add
branch
from
36ffb06
to
c357517
Compare
AThousandShips
force-pushed
the
folder_color_add
branch
from
c357517
to
0f02619
Compare
|
Thanks! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that moved and renamed folders transfer their color, and clears the color for removed entries
Currently this does not update anything on moving, renaming, or deleting folders from the OS file manager, could add further logic to handle this but keeping it simple here for these specific cases
This also does not copy the color on duplication, which I think isn't expected, if someone wants that please ask and I can open a dedicated PR for it