Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add render mode to use world coordinates in canvas item shader #81160

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Add render mode to use world coordinates in canvas item shader #81160

merged 1 commit into from
Sep 19, 2023

Conversation

paddy-exe
Copy link
Contributor

@paddy-exe paddy-exe commented Aug 30, 2023 •
edited
Loading

By using the render mode world_vertex_coords you can automatically use the vertex coordinates in world space

Supersedes #24002
Fixes godotengine/godot-docs#7860
Fixes #19800

@paddy-exe paddy-exe requested a review from a team as a code owner August 30, 2023 13:01
clayjohn
clayjohn reviewed Aug 30, 2023
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! The same shader changes will be needed in the compatibility renderer as well.

servers/rendering/renderer_rd/shaders/canvas.glsl Outdated Show resolved Hide resolved
@paddy-exe paddy-exe force-pushed the canvas-uv-world-space branch 2 times, most recently from 5acefc4 to 53c765a Compare August 30, 2023 13:26
@paddy-exe paddy-exe changed the title Add option to use world coordinates in canvas item shader Add render mode to use world coordinates in canvas item shader Aug 30, 2023
@paddy-exe
Add option to use world coordinates in canvas item shader
c98ab5a 
By using the render mode `world_vertex_coords` you can automatically use the vertex coordinates in world space
@YuriSizov YuriSizov added this to the 4.2 milestone Aug 30, 2023
BastiaanOlij
BastiaanOlij approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@BastiaanOlij BastiaanOlij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, pretty straight forward improvement

@akien-mga akien-mga merged commit 9a1b4f3 into godotengine:master Sep 19, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga mentioned this pull request Sep 19, 2023
Closed
@paddy-exe paddy-exe deleted the canvas-uv-world-space branch September 19, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BastiaanOlij BastiaanOlij BastiaanOlij approved these changes

@clayjohn clayjohn Awaiting requested review from clayjohn

Assignees
No one assigned
Labels
feature proposal topic:rendering topic:shaders topic:2d
Projects
None yet
Milestone
4.2
6 participants
@paddy-exe @akien-mga @BastiaanOlij @clayjohn @Calinou @YuriSizov