zlib/minizip: Update to version 1.3 #81111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstreams the fix from godotengine#73310, so we can remove that patch. Remove `infback.c` which we stopped compiling after godotengine#79273. The `OF` macro was also removed so I can drop the patch where I yell at Gentoo developers.
akien-mga
added
enhancement
topic:thirdparty
cherrypick:3.x
RedworkDE
approved these changes
Sep 1, 2023
YuriSizov
removed
the
cherrypick:4.1
|
Cherry-picked for 4.1.3. |
|
Cherry-picked for 3.6. |
akien-mga
removed
the
cherrypick:3.x
akien-mga
added
the
cherrypick:3.5
|
Cherry-picked for 3.5.4. |
akien-mga
removed
the
cherrypick:3.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstreams the fix from #73310, so we can remove that patch. Remove
infback.cwhich we stopped compiling after #79273. (Note for3.xcherrypick: that file should be removed fromcore/SCsubtoo.)The
OFmacro was also removed so I can drop the patch where I yell at Gentoo developers.Would be nice if we could look at upstreaming the seek functionality we added to minizip, so that we no longer need to rely on a hard fork and can compile Godot against distro minizip too.