Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VoxelGI CameraAttributes exposure normalization handling #81067

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

bitsawer
Copy link
Member

Exposure value is used both when baking and during runtime, but currently VoxelGI only sets the runtime exposure normalization value when it is baked. This means that when the resource is freed and reloaded later, this setting is not updated properly and the normalization is not applied. This PR updates the normalization value when either voxel data or camera data is changed.

@bitsawer bitsawer added this to the 4.2 milestone Aug 28, 2023
@bitsawer bitsawer requested a review from a team August 28, 2023 10:55
@bitsawer bitsawer requested a review from a team as a code owner August 28, 2023 10:55
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally (rebased on top of master 031f6de), it works as expected.

I've also tested #78373, but this PR does not fix that particular issue.

Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! I haven't tested locally, but I trust the reviews that came before mine

@clayjohn clayjohn added the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Aug 29, 2023
@akien-mga akien-mga merged commit b272d7e into godotengine:master Aug 29, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Oct 24, 2023
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VoxelGI does not preserve CameraAttributes across scene reloads
5 participants