Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unit suffix for HingeJoint3D's target velocity #80523

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Fix unit suffix for HingeJoint3D's target velocity #80523

merged 1 commit into from
Oct 17, 2023

Conversation

ElMikosch
Copy link
Contributor

@ElMikosch ElMikosch commented Aug 11, 2023 •
edited by AThousandShips
Loading

Fix #80505

I changed the suffix for HingeJoint3D/Motor/TargetVelocity to °/s as suggested in the Issue.

image

@ElMikosch ElMikosch requested a review from a team as a code owner August 11, 2023 17:10
@AThousandShips AThousandShips added this to the 4.2 milestone Aug 11, 2023
@AThousandShips AThousandShips mentioned this pull request Aug 12, 2023
Closed
@MewPurPur
Copy link
Contributor

MewPurPur commented Aug 12, 2023 •
edited
Loading

Did the issue not suggest radians?

Edit: Just checked, it's not radians.

@ElMikosch ElMikosch force-pushed the fix_hingejoint3d_target_velocity_suffix branch from 5d4f8ea to 7bd2f24 Compare August 13, 2023 10:54
@YuriSizov YuriSizov changed the title Fixed the suffix for Target Velocity Fix unit suffix for HingeJoint3D's target velocity Oct 17, 2023
@YuriSizov YuriSizov force-pushed the fix_hingejoint3d_target_velocity_suffix branch from 7bd2f24 to d4ced25 Compare October 17, 2023 16:55
AThousandShips
AThousandShips approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, unsure if the range is reasonable but can investigate that as a future change, along with other physics properties

@akien-mga akien-mga merged commit 30bdf77 into godotengine:master Oct 17, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@mihe mihe mentioned this pull request Oct 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuriSizov YuriSizov YuriSizov approved these changes

@AThousandShips AThousandShips AThousandShips approved these changes

Assignees
No one assigned
Labels
bug topic:editor topic:physics topic:3d
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

HingeJoint3D has wrong inspector unit type.
5 participants
@ElMikosch @MewPurPur @akien-mga @YuriSizov @AThousandShips