Remove CanvasItem::_invalidate_global_transform
#80320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only use of that function can be replaced by `_notify_transform`, which makes the `propagate_call` unnecessary. As far as I can tell, the `data.blocked`-checks of `propagate_call` are not needed in this case, because `_invalidate_global_transform` causes no user-noticeable changes.
Sauermann
force-pushed
the
fix-remove-invalidation-function
branch
from
5e88139
to
7f317ef
Compare
akien-mga
approved these changes
Aug 30, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only use of that function can be replaced by
_notify_transform, which makes thepropagate_callunnecessary.As far as I can tell, the
data.blocked-checks ofpropagate_callare not needed in this case, because_invalidate_global_transformcauses no user-noticeable changes.Updated 2023-08-30: With #80105 merged, this PR can now be considered ready.