Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore null "id" in tile source proxy #80135

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Aug 1, 2023

Fixes "a number is required" error.

@YuriSizov
Copy link
Contributor

Is it not needed on the line 996 as well?

@KoBeWi
Copy link
Member Author

KoBeWi commented Aug 1, 2023

It's not, but there might be some underlying issue here. The error appears, because the first "id" value is null. Actual numbers don't need explicit casting.

@KoBeWi
Copy link
Member Author

KoBeWi commented Aug 1, 2023

I pushed an alternate fix.

Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me.

@akien-mga akien-mga changed the title Cast tile source "id" to int Ignore null "id" in tile source proxy Aug 2, 2023
@akien-mga akien-mga merged commit f823bcc into godotengine:master Aug 2, 2023
13 checks passed
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the A_NumbER_Is_REQuIrEd branch August 2, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants