Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make blend file importer warnings translatable #79807

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Make blend file importer warnings translatable #79807

merged 1 commit into from
Jul 24, 2023

Conversation

timothyqiu
Copy link
Member

New users will surely be welcomed with this warning. Localizing it makes it less confusing 😛

@timothyqiu timothyqiu added enhancement topic:editor cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Jul 23, 2023
@timothyqiu timothyqiu added this to the 4.2 milestone Jul 23, 2023
@timothyqiu timothyqiu requested a review from a team as a code owner July 23, 2023 03:21
fire
fire approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a common error that should be translated.

@YuriSizov YuriSizov merged commit feb8594 into godotengine:master Jul 24, 2023
13 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@timothyqiu timothyqiu deleted the what-does-the-blend-thing-say branch July 24, 2023 17:54
@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Sep 21, 2023
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fire fire fire approved these changes

Assignees
No one assigned
Labels
enhancement topic:editor
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@timothyqiu @YuriSizov @fire