Clarify set_multiplayer_authority documentation regarding propagation
#79764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuriSizov
changed the title
set_multiplayer_authority documentation regarding propagation
mhilbrunner
approved these changes
Jul 25, 2023
|
Thanks! And congrats on your first merged Godot PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs state
authorityof a node is inherited from the parent but it is incorrect. It defaults to 1 (server's id) for every node. So I changed the part about it. I also added a sentence to clarify that newly added children do not inherit their parent'sauthority.I recently got bitten by this doc. I checked the source code and figured that info is incorrect. I also double checked it by asking it on
#networkingchannel.