Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Net/ENet] Better handle truncated socket messages. #79699

Merged
merged 2 commits into from
Jul 20, 2023

Conversation

Faless
Copy link
Collaborator

@Faless Faless commented Jul 20, 2023

Update ENet to latest upstream master branch (ea4607a90dbfbcf4da2669ea998585253d8e70b1 at the time of the PR), plus lsalzman/enet@2a85cd6 , which fixes a DoS vulnerability in ENet library code originally discovered by @Facundo15 and reported to the Godot Security Team.

The fix is included in 4.0.4, 3.5.3, and 4.1.2, and all 4.2 beta releases.

See #79704 for the 3.x version.

@Faless Faless added bug topic:network cherrypick:4.0 cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Jul 20, 2023
@Faless Faless added this to the 4.x milestone Jul 20, 2023
@Faless Faless requested review from a team as code owners July 20, 2023 10:32
@YuriSizov YuriSizov modified the milestones: 4.x, 4.2 Jul 20, 2023
@YuriSizov YuriSizov merged commit 8a9af36 into godotengine:master Jul 20, 2023
13 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@YuriSizov
Copy link
Contributor

Cherry-picked for 4.0.4.

@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.2.

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants