Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when calling get_video_adapter_* in a thread #79528

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Fix crash when calling get_video_adapter_* in a thread #79528

merged 1 commit into from
Jul 20, 2023

Conversation

univeous
Copy link
Contributor

Fixes #79503 .

@univeous univeous requested a review from a team as a code owner July 16, 2023 01:21
@Calinou Calinou added this to the 4.2 milestone Jul 16, 2023
@Calinou Calinou added the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jul 16, 2023
@univeous univeous force-pushed the video_adapter_fix branch 2 times, most recently from 86ec978 to 2fbfabf Compare July 16, 2023 01:33
@univeous univeous requested review from a team as code owners July 19, 2023 14:26
@univeous
Copy link
Contributor Author

univeous commented Jul 19, 2023 •
edited
Loading

It seems I somehow requested a bunch of reviewers 🥲. Is it ok or there is a way to reverse it?

@univeous @clayjohn
Fix crash when calling get_video_adapter_* in a thread
0a64abe 
co-authored-by: Clay John <claynjohn@gmail.com>
clayjohn
clayjohn approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@AThousandShips AThousandShips removed request for a team July 19, 2023 15:30
@YuriSizov YuriSizov changed the title Fix crash when calling get_video_adapter_* in a thread Fix crash when calling get_video_adapter_* in a thread Jul 20, 2023
@YuriSizov YuriSizov merged commit dd05012 into godotengine:master Jul 20, 2023
13 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@univeous univeous deleted the video_adapter_fix branch July 20, 2023 14:31
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.2.

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RandomShaper RandomShaper RandomShaper approved these changes

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
bug crash topic:rendering
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Game crash when using compatibility rendering method
5 participants
@univeous @YuriSizov @RandomShaper @clayjohn @Calinou