Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide/show AcceptDialog's button spacer on button visibility changed #79274

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Hide/show AcceptDialog's button spacer on button visibility changed #79274

merged 1 commit into from
Jul 11, 2023

Conversation

kleonc
Copy link
Member

@kleonc kleonc commented Jul 10, 2023

Fixes #79096.

Before After
0dyPvBDWdQ GitHubDesktop_ZolZrNAUIs

@kleonc kleonc added bug topic:editor cherrypick:4.0 cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Jul 10, 2023
@kleonc kleonc added this to the 4.2 milestone Jul 10, 2023
@kleonc kleonc requested a review from a team as a code owner July 10, 2023 10:22
YuriSizov
YuriSizov reviewed Jul 10, 2023
View reviewed changes
scene/gui/dialogs.cpp Outdated Show resolved Hide resolved
@kleonc kleonc force-pushed the accept-dialog-spacer-visibility branch from a0aa9e5 to 0c53154 Compare July 11, 2023 07:52
kleonc
kleonc commented Jul 11, 2023
View reviewed changes
scene/gui/dialogs.cpp Outdated Show resolved Hide resolved
@kleonc kleonc force-pushed the accept-dialog-spacer-visibility branch from 0c53154 to 6a1e934 Compare July 11, 2023 09:54
YuriSizov
YuriSizov reviewed Jul 11, 2023
View reviewed changes
scene/gui/dialogs.cpp Outdated Show resolved Hide resolved
YuriSizov
YuriSizov approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@YuriSizov YuriSizov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conceptually it's great, just some things to iron out.

@kleonc kleonc force-pushed the accept-dialog-spacer-visibility branch from 6a1e934 to 30a9c90 Compare July 11, 2023 10:19
@YuriSizov YuriSizov merged commit 23318e8 into godotengine:master Jul 11, 2023
13 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.1.

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jul 11, 2023
@kleonc kleonc deleted the accept-dialog-spacer-visibility branch July 11, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KoBeWi KoBeWi KoBeWi left review comments

@YuriSizov YuriSizov YuriSizov approved these changes

Assignees
No one assigned
Labels
bug topic:editor
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Version upgrade/downgrade confirmation dialog buttons misaligned
3 participants
@kleonc @YuriSizov @KoBeWi