Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doctool: Remove version attribute from XML header #79092

Merged

Conversation

akien-mga
Copy link
Member

We don't use that info for anything, and it generates unnecessary diffs every time we bump the minor version (and CI failures if we forget to sync some files from opt-in modules (mono, text_server_fb).

We don't use that info for anything, and it generates unnecessary diffs
every time we bump the minor version (and CI failures if we forget to
sync some files from opt-in modules (mono, text_server_fb).
@akien-mga akien-mga added this to the 4.2 milestone Jul 6, 2023
@akien-mga akien-mga requested review from a team as code owners July 6, 2023 08:16
@akien-mga akien-mga removed request for a team July 6, 2023 08:17
@akien-mga akien-mga removed request for a team July 6, 2023 08:17
@akien-mga akien-mga merged commit 69dbbcc into godotengine:master Jul 7, 2023
13 checks passed
@akien-mga akien-mga deleted the doctool-remove-version-attribute branch July 7, 2023 07:07
@akien-mga akien-mga added the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Sep 11, 2024
@akien-mga
Copy link
Member Author

Cherry-picked for 3.7.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants