Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[macOS] Fix set_native_icon crash with empty or invalid ICNS file. #79010

Merged
merged 1 commit into from
Jul 7, 2023
Merged

[macOS] Fix set_native_icon crash with empty or invalid ICNS file. #79010

merged 1 commit into from
Jul 7, 2023

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Jul 4, 2023

Fixes #78819

@bruvzg bruvzg added this to the 4.x milestone Jul 4, 2023
@bruvzg bruvzg requested a review from a team as a code owner July 4, 2023 06:10
@akien-mga akien-mga changed the title [macOS] Fix set_native_icon crash with empty or invalid ICNS file. [macOS] Fix set_native_icon crash with empty or invalid ICNS file. Jul 6, 2023
@akien-mga akien-mga merged commit 9522ef6 into godotengine:master Jul 7, 2023
13 checks passed
@akien-mga
Copy link
Member

Thanks!

@YuriSizov YuriSizov modified the milestones: 4.x, 4.2 Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug crash platform:macos topic:porting
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

MacOS crash when trying to Run project with corrupted custom icon (.icns)
3 participants
@bruvzg @akien-mga @YuriSizov