Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scrolling to overwrite dialog #77179

Merged
merged 1 commit into from
May 22, 2023
Merged

Add scrolling to overwrite dialog #77179

merged 1 commit into from
May 22, 2023

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented May 17, 2023

Fixes #76253
Supersedes #76391

godot.windows.editor.dev.x86_64_Yg9hrP8hd7.mp4

@KoBeWi KoBeWi added this to the 4.1 milestone May 17, 2023
@KoBeWi KoBeWi requested a review from a team as a code owner May 17, 2023 22:11
@dalexeev
Copy link
Member

dalexeev commented May 18, 2023 •
edited
Loading

I think it's better to add scrolling to AcceptDialog (with an exposed property, see the comment) if we decide it's not needed for Label (comment).

@YuriSizov YuriSizov merged commit 903dda8 into godotengine:master May 22, 2023
@YuriSizov
Copy link
Contributor

Thanks!

@YuriSizov YuriSizov mentioned this pull request May 22, 2023
Closed
@KoBeWi KoBeWi deleted the that's_a_lot_of_files branch May 22, 2023 18:25
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.0.4. Made some adjustments while picking to account for #75330 not being a part of 4.0 (and not really being pickable at this point).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuriSizov YuriSizov YuriSizov approved these changes

Assignees
No one assigned
Labels
bug topic:editor usability
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

File overwrite confirmation dialogue can be taller than screen
3 participants
@KoBeWi @dalexeev @YuriSizov