Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve file move and copy operations #75330

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Mar 25, 2023

Right now we have 2 ways to move files and 1 way to copy files. First is drag and drop. It moves files, or copies if you hold Ctrl. The second one is "Move To" context menu option, which shows a nice folder tree, where you can select target directory and your file(s) is/are moved.

The Move To option is particularly nice, because you can easily move files between folders that are very far apart (which is not that convenient with dragging). So I though - what if the dialog had copy option? And then I also refactored both operations and added some extras.

godot.windows.editor.dev.x86_64_ETkI3cUnKW.mp4

Move To was renamed to Move/Copy To, and it becomes copy when you select a checkbox. Previously when you copied files, the new files were just renamed in case of conflict. And when you moved files, there was a confirmation dialog for overwriting. This is now unified. Both operations now ask you in case of conflict and offer "Keep Both" option that renames the file. Which means you can copy & overwrite and move & rename (to File (2) etc.).

@KoBeWi KoBeWi added this to the 4.x milestone Mar 25, 2023
@KoBeWi KoBeWi requested a review from a team as a code owner March 25, 2023 20:03
@akien-mga akien-mga modified the milestones: 4.x, 4.1 Apr 3, 2023
@akien-mga akien-mga merged commit 41ed64a into godotengine:master Apr 3, 2023
@KoBeWi KoBeWi deleted the make_haste_with_copy_paste branch April 3, 2023 14:24
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants