Reworked Particle Turbulence #77154
Merged
Reworked Particle Turbulence #77154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RPicster
force-pushed
the
raffa/particles-noise-improvement
branch
from
fe2e6c0
to
91bdd40
Compare
clayjohn
approved these changes
May 17, 2023
Calinou
approved these changes
May 17, 2023
akien-mga
changed the title
|
Does this break compatibility for existing projects that use particle turbulence? Thanks. |
Nope |
|
Ah - I had taken a bit of a break. Thanks for picking up my slack! |
|
@KdotJPG thanks to you for all the back and forth before! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase of #64606
@QbieShay asked me if I could rebase the original PR and have a final look over it as @KdotJPG was not responding and 4.1 comes closer ;)
Everthing works, looks good and I adjusted some mismatches between default values and values in the docs.
I also changed the default value for the
turbulence_noise_speed_randomas it made no sense to have no movement by default - And it also had default movement in the old version of the turbulence.