Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Particle turbulence behaves very differently in 4.1.dev3 #77491

Closed
Novark opened this issue May 25, 2023 · 5 comments · Fixed by #77631
Closed

Particle turbulence behaves very differently in 4.1.dev3 #77491

Novark opened this issue May 25, 2023 · 5 comments · Fixed by #77631

Comments

@Novark
Copy link

Novark commented May 25, 2023

Godot version

4.1.dev3.official [a67d37f]

System information

Windows 11 [Vulkan]

Issue description

The work performed in #77154 drastically changed the visual characteristics of particle turbulence. I am no longer able to get the same "turbulent" behaviour that existed before these changes - no matter which turbulence settings I change. Please let me know if there's something I'm missing about the new implementation that would give this result.

image

Steps to reproduce

To reproduce this is fairly simple:

  1. Create a GPUParticles2D Node
  2. Emit a significant number of particles (I'm emitting 50,000)
  3. Set Initial Velocity [Max] to around 250, and Direction Spread to 180. Enable turbulence
  4. Set the turbulence_influence_min property to 0.1 (default) and turbulence_influence_max to 1
  5. Observe how the turbulence appears in v4.1.dev3.official with the changes in Reworked Particle Turbulence #77154 versus the previous build without these changes. The new implementation just results in some minor particle "jitter", but not the actual turbulence that it's supposed to have.

Minimal reproduction project

No sample project provided, as the reproduction is quite simple to replicate.

@Calinou
Copy link
Member

Calinou commented May 25, 2023

cc @KdotJPG @RPicster

@KdotJPG
Copy link
Contributor

KdotJPG commented May 27, 2023

I was able to get the turbulent look in both, but I had to change the scale for some reason.

I don't know why this difference is showing up. No changes to the scale value curve were merged since 4.0, and the same is the case for how it's effectively used.

turbulence40
turbulence41

@Novark
Copy link
Author

Novark commented May 27, 2023

I was able to get the turbulent look in both, but I had to change the scale for some reason.

I don't know why this difference is showing up. No changes to the scale value curve were merged since 4.0, and the same is the case for how it's effectively used.

[Image]
[Image]

Edit: Disregard my original comment below, I was looking at the wrong image when I copied your settings. I was able to produce the same results as you by changing the noise scale as well - which I agree is an odd change. The scale characteristics are bizzare - there's basically no effect at either end of the value range - it needs to be right around 3.0 to see any turbulence, and even then, small changes centered around that value seem to result in wildly different visual behaviour.

That's very strange...I just tested it again with your exact settings and see the same result that I got before - no turbulence.

@KdotJPG
Copy link
Contributor

KdotJPG commented May 29, 2023

^ found the solution!

@Novark
Copy link
Author

Novark commented May 29, 2023

^ found the solution!

Glad to hear it! Do you know if this change would also resolve #74541? It may be worth taking a look at while you're in the same headspace having just solved this one.

KdotJPG added a commit to KdotJPG/godot that referenced this issue May 31, 2023
@YuriSizov YuriSizov added this to the 4.1 milestone May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants