Fix code completion override of home and end keys

[adamscott]

Changes the behaviour of the home and end keys when the autocomplete popup is open.

Rather than going to the top and the bottom of the list, home and end closes the autocomplete popup and work as usual.

Fixes #71471

[Paulb23]

Checked a few other editors, this seems to be the common behaviour. Couple of unit tests are failing on macOS otherwise looks good.

[adamscott]

I wonder if macOS has another behavior when using home and end keys.

[groud]

Approved in Input PR review

Edit: the failing check needs a fix first though.

[Calinou]

Tested locally (rebased on top of master d31794c), it works as expected.

simplescreenrecorder-2023-10-05_22.36.59.mp4

TIL pressing Home several times cycles between the beginning of the line with and without leading whitespace (like in VS Code) 🙂

An unit test needs to be fixed before this can be merged.

[adamscott]

I installed a macOS virtual machine to test the issue (why-oh-why it doesn't pass the unit tests on macOS!?)

[bruvzg]

why-oh-why it doesn't pass the unit tests on macOS!?

I suspect it's related to SEND_GUI_ACTION("ui_end");, this macro is sending a key combination for the action (End key on all platforms). On other platforms, ui_text_caret_line_end is the same, but not on macOS (ui_text_caret_line_end is Command+Right and Ctrl+E).

[adamscott]

why-oh-why it doesn't pass the unit tests on macOS!?

I suspect it's related to SEND_GUI_ACTION("ui_end");, this macro is sending a key combination for the action (End key on all platforms). On other platforms, ui_text_caret_line_end is the same, but not on macOS (ui_text_caret_line_end is Command+Right and Ctrl+E).

Yes. I just found out that by reading that Reddit comment.

[adamscott]

I just added the same functionality for ui_text_caret_line_start and ui_text_caret_line_end and disabled the tests for ui_home and ui_end on macOS removed ui_home and ui_end.

[akien-mga]

I think it's more readable on a single line than on three like this (I know it's clang-format doing it but it makes it not worth it).

[adamscott]

That's a left over of these being 4 checks instead of 2. I'm correcting this.

[akien-mga]

Thanks!