[3.x] PopupMenu rework and enhancements #66711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricEzaM
reviewed
Oct 2, 2022
|
It's a mix. I started by cherry-picking your commit and fixing conflicts, but then I compared with both |
rsubtil
force-pushed
the
port_popup_menu_rework
branch
from
7710361
to
7882861
Compare
Many scrolling behaviour improvements and the ability to limit popup size.
rsubtil
force-pushed
the
port_popup_menu_rework
branch
from
7882861
to
6a5992c
Compare
akien-mga
approved these changes
Jan 21, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #41640 for
3.x(cc @EricEzaM)From my tests I didn't encounter any major breaking changes but there might be details about the popup behavior that I've missed.
I've done my best to port the PR with minimal changes, but also avoid having to massively change the existing codebase to accommodate for it. The only major deviation I had to do was adding in the variable
max_sizefor setting the size, since that variable comes fromWindow, whichPopupwas refactored to be a child of it (#37317)